linux-kernel - Re: [PATCH v2] mtd: rawnand: ams-delta: Drop board specific partition info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Apr 2019 21:11:14 +0200
From:   Janusz Krzysztofik <jmkrzyszt@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Aaro Koskinen <aaro.koskinen@....fi>,
        Tony Lindgren <tony@...mide.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mtd@...ts.infradead.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: ams-delta: Drop board specific partition info

Hi Miquèl,

I'm wondering if we could register up a custom mtd partition parser from the 
board file.  It could return a pointer to a statically defined table.  Then we 
could add its name to the list of parsers the driver is going to try if the 
board is enabled in .config.
Would that be acceptable from the MTD subsystem point of view?

Thanks,
Janusz


On Thursday, April 18, 2019 8:49:29 AM CEST Miquel Raynal wrote:
> Hi Janusz,
> 
> Janusz Krzysztofik <jmkrzyszt@...il.com> wrote on Thu, 18 Apr 2019
> 01:09:59 +0200:
> 
> > Hi Aaro, Tony,
> > 
> > On Wednesday, April 17, 2019 11:40:10 AM CEST Miquel Raynal wrote:
> > > Hi Janusz,
> > > 
> > > Janusz Krzysztofik <jmkrzyszt@...il.com> wrote on Sun, 24 Mar 2019
> > > 23:33:44 +0100:
> > >   
> > > > After recent modifications, only a hardcoded partition info makes
> > > > the driver device specific.  Other than that, the driver uses GPIO
> > > > exclusively and can be used on any hardware.
> > > > 
> > > > Drop the partition info and use MTD partition parser with default list
> > > > of parser names instead.  For the OF parser to work correctly, pass
> > > > device of_node to mtd.
> > > > 
> > > > Amstrad Delta users should append the following partition info to 
their
> > > > kernel command line, possibly by embedding it in CONFIG_CMDLINE:
> > > > 
> > > > mtdparts=ams-delta-nand:3584k(Kernel),256k(u-boot),256k(u-
boot_params),\
> > > > 256k(Amstrad_LDR),27m(File_system),768k(PBL_reserved).
> > > > 
> > > > For their convenience, CONFIG_MTD_CMDLINE_PARTS symbol is selected
> > > > automatically from that board Kconfig if this NAND driver is also
> > > > selected.
> > > > 
> > > > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@...il.com>
> > > > Cc: Tony Lindgren <tony@...mide.com>
> > > > ---  
> > > 
> > > FYI I am okay with the change but I am waiting for acks before applying
> > > it.  
> > 
> > May we have an ack from you?
> > 
> > If still not convinced with my clarifications, I can add a comment to help 
text 
> > in Kconfig, either squashed or in a follow up patch, on the requirement of 
> > appending mtdparts parameter to command line.  What do you think?
> 
> In the same patch I guess that would be fine.
> 
> Thanks,
> Miquèl
>