linux-kernel - Re: [PATCH v3] usb/hcd: Send a uevent signaling that the host controller had died

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201904190446.57TY0W6W%lkp@intel.com>
Date:   Fri, 19 Apr 2019 04:59:26 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Raul E Rangel <rrangel@...omium.org>
Cc:     kbuild-all@...org, linux-usb@...r.kernel.org, groeck@...omium.org,
        oneukum@...e.com, djkurtz@...omium.org, zwisler@...omium.org,
        Raul E Rangel <rrangel@...omium.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Dmitry Torokhov <dtor@...omium.org>,
        linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v3] usb/hcd: Send a uevent signaling that the host
 controller had died

Hi Raul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.1-rc5 next-20190418]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Raul-E-Rangel/usb-hcd-Send-a-uevent-signaling-that-the-host-controller-had-died/20190419-033556
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-randconfig-x014-201915 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


All error/warnings (new ones prefixed by >>):

   In file included from include/linux/srcu.h:21:0,
                    from include/linux/notifier.h:16,
                    from include/linux/memory_hotplug.h:7,
                    from include/linux/mmzone.h:749,
                    from include/linux/gfp.h:6,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:22,
                    from include/linux/module.h:13,
                    from drivers/usb/core/hcd.c:13:
   drivers/usb/core/hcd.c: In function '__usb_create_hcd':
>> drivers/usb/core/hcd.c:2566:29: error: 'hcd_died_work' undeclared (first use in this function); did you mean 'schedule_work'?
     INIT_WORK(&hcd->died_work, hcd_died_work);
                                ^
   include/linux/workqueue.h:245:20: note: in definition of macro '__INIT_WORK'
      (_work)->func = (_func);    \
                       ^~~~~
>> drivers/usb/core/hcd.c:2566:2: note: in expansion of macro 'INIT_WORK'
     INIT_WORK(&hcd->died_work, hcd_died_work);
     ^~~~~~~~~
   drivers/usb/core/hcd.c:2566:29: note: each undeclared identifier is reported only once for each function it appears in
     INIT_WORK(&hcd->died_work, hcd_died_work);
                                ^
   include/linux/workqueue.h:245:20: note: in definition of macro '__INIT_WORK'
      (_work)->func = (_func);    \
                       ^~~~~
>> drivers/usb/core/hcd.c:2566:2: note: in expansion of macro 'INIT_WORK'
     INIT_WORK(&hcd->died_work, hcd_died_work);
     ^~~~~~~~~

vim +2566 drivers/usb/core/hcd.c

  2565	
> 2566		INIT_WORK(&hcd->died_work, hcd_died_work);
  2567	
  2568		hcd->driver = driver;
  2569		hcd->speed = driver->flags & HCD_MASK;
  2570		hcd->product_desc = (driver->product_desc) ? driver->product_desc :
  2571				"USB Host Controller";
  2572		return hcd;
  2573	}
  2574	EXPORT_SYMBOL_GPL(__usb_create_hcd);
  2575	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29985 bytes)