linux-kernel - Re: [PATCH v5 0/9] mtd: rawnand: denali: exec_op(), controller/chip separation, and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190418181250.14d7da9c@xps13>
Date:   Thu, 18 Apr 2019 18:12:50 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mtd@...ts.infradead.org,
        Boris Brezillon <bbrezillon@...nel.org>,
        devicetree@...r.kernel.org,
        Brian Norris <computersforpeace@...il.com>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5 0/9] mtd: rawnand: denali: exec_op(), controller/chip
 separation, and cleanups

Hi Masahiro,

Masahiro Yamada <yamada.masahiro@...ionext.com> wrote on Tue,  2 Apr
2019 13:03:00 +0900:

> I took time for the Denali driver to catch up with the latest framework.
> 
>  - switch over to exec_op() and remove legacy hooks
> 
>  - separate controller/chips
> 
>  - various cleanups
> 
> Major changes in v5:
> 
>   - Passing both nand_chip and denali is redundant.
>     Pass only nand_chip to local helpers.
> 
> Major changes in v4:
>   - Add denali_exec_out() and denali_exec_in()
>     in order to make denali_exec_instr() readable
> 
>   - Make .read_page_raw() and .write_page_raw() even simpler
>     by giving up the performance
> 
> Major changes in v3:
>   - Drop "mtd: rawnand: denali: use more precise timeout for NAND_OP_WAITRDT_INSTR"
>     entirely according to the review comments in v2
> 
>   - Add comments to helpers in 2/9
> 
> 
> 
> Masahiro Yamada (9):
>   mtd: rawnand: denali: use more nand_chip pointers for internal
>     functions
>   mtd: rawnand: denali: refactor raw page accessors
>   mtd: rawnand: denali: remove unneeded casts in denali_{read,write}_pio
>   mtd: rawnand: denali: switch over to ->exec_op() from legacy hooks
>   mtd: rawnand: denali: use bool type instead of int where appropriate
>   mtd: rawnand: denali_pci: rename goto labels
>   mtd: rawnand: denali: decouple controller and NAND chips
>   mtd: rawnand: denali: remove DENALI_NR_BANKS macro
>   mtd: rawnand: denali: clean up coding style
> 
>  .../devicetree/bindings/mtd/denali-nand.txt        |   40 +-
>  drivers/mtd/nand/raw/denali.c                      | 1146 ++++++++++----------
>  drivers/mtd/nand/raw/denali.h                      |  117 +-
>  drivers/mtd/nand/raw/denali_dt.c                   |   98 +-
>  drivers/mtd/nand/raw/denali_pci.c                  |   38 +-
>  5 files changed, 823 insertions(+), 616 deletions(-)
> 


Applied to 
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git 
branch nand/next.

Thanks,
Miquèl



Thanks,
Miquèl