linux-kernel - Re: [PATCH] lib: scatterlist: Fix to support no mapped sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871s1ymg1k.fsf@belgarion.home>
Date:   Fri, 19 Apr 2019 12:43:19 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Zhou Wang <wangzhou1@...ilicon.com>
Cc:     <axboe@...com>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH] lib: scatterlist: Fix to support no mapped sg

Zhou Wang <wangzhou1@...ilicon.com> writes:

> In function sg_split, the second sg_calculate_split will return -EINVAL
> when in_mapped_nents is 0.
>
> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
> original sgl.
>
> Signed-off-by: Zhou Wang <wangzhou1@...ilicon.com>
That's right. May I know what is the usecase which led you to this fix ?

Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>

--
Robert