linux-kernel - Re: [PATCH] lib: scatterlist: Fix to support no mapped sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 Apr 2019 11:48:12 +0800
From:   Zhou Wang <wangzhou1@...ilicon.com>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
CC:     <axboe@...com>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH] lib: scatterlist: Fix to support no mapped sg

On 2019/4/19 18:43, Robert Jarzmik wrote:
> Zhou Wang <wangzhou1@...ilicon.com> writes:
> 
>> In function sg_split, the second sg_calculate_split will return -EINVAL
>> when in_mapped_nents is 0.
>>
>> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
>> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
>> original sgl.
>>
>> Signed-off-by: Zhou Wang <wangzhou1@...ilicon.com>
> That's right. May I know what is the usecase which led you to this fix ?

I posted a patchset to support HiSilicon compression engine:
https://lkml.org/lkml/2019/1/23/358. As Herber Xu suggested, it should use
new crypto acomp API which uses sgl as data input and output. However, our
hardware can not handle compress head for input/output data, so I need split
input/output sgl firstly which is not mapped sgl.

New version of HiSilicon compression engine driver has not been posted to
community yet. I will do this later.

> 
> Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Many thanks for your review,
Zhou

> 
> --
> Robert
> 
> .
>