lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 20 Apr 2019 13:01:51 -0400
From:   Pavel Tatashin <>
To:     Dan Williams <>
Cc:     James Morris <>, Sasha Levin <>,
        Linux Kernel Mailing List <>,
        Linux MM <>,
        linux-nvdimm <>,
        Andrew Morton <>,
        Michal Hocko <>,
        Dave Hansen <>,
        Keith Busch <>,
        Vishal L Verma <>,
        Dave Jiang <>,
        Ross Zwisler <>,
        Tom Lendacky <>,
        "Huang, Ying" <>,
        Fengguang Wu <>,
        Borislav Petkov <>,
        Bjorn Helgaas <>,
        Yaowei Bai <>,
        Takashi Iwai <>,
        Jérôme Glisse <>
Subject: Re: [v1 2/2] device-dax: "Hotremove" persistent memory that is used
 like normal RAM

> > Thank you for looking at this.  Are you saying, that if drv.remove()
> > returns a failure it is simply ignored, and unbind proceeds?
> Yeah, that's the problem. I've looked at making unbind able to fail,
> but that can lead to general bad behavior in device-drivers. I.e. why
> spend time unwinding allocated resources when the driver can simply
> fail unbind? About the best a driver can do is make unbind wait on
> some event, but any return results in device-unbind.

Hm, just tested, and it is indeed so.

I see the following options:

1. Move hot remove code to some other interface, that can fail. Not
sure what that would be, but outside of unbind/remove_id. Any
2. Option two is don't attept to offline memory in unbind. Do
hot-remove memory in unbind if every section is already offlined.
Basically, do a walk through memblocks, and if every section is
offlined, also do the cleanup.


Powered by blists - more mailing lists