lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Apr 2019 19:07:50 +0200 From: Corentin Labbe <clabbe.montjoie@...il.com> To: fenghua.yu@...el.com, tony.luck@...el.com Cc: linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ia64: agp: Replace empty define with do while On Wed, Dec 20, 2017 at 08:16:13PM +0100, Corentin Labbe wrote: > It's dangerous to use empty code define. > Furthermore it lead to the following warning: > drivers/char/agp/generic.c: In function « agp_generic_destroy_page »: > drivers/char/agp/generic.c:1266:28: attention : suggest braces around empty body in an « if » statement [-Wempty-body] > > So let's replace emptyness by "do {} while(0)" > > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com> Hello Gentle ping Regards > --- > arch/ia64/include/asm/agp.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/ia64/include/asm/agp.h b/arch/ia64/include/asm/agp.h > index 2b451c4496da..0261507dc264 100644 > --- a/arch/ia64/include/asm/agp.h > +++ b/arch/ia64/include/asm/agp.h > @@ -14,8 +14,8 @@ > * in coherent mode, which lets us map the AGP memory as normal (write-back) memory > * (unlike x86, where it gets mapped "write-coalescing"). > */ > -#define map_page_into_agp(page) /* nothing */ > -#define unmap_page_from_agp(page) /* nothing */ > +#define map_page_into_agp(page) do { } while (0) > +#define unmap_page_from_agp(page) do { } while (0) > #define flush_agp_cache() mb() > > /* GATT allocation. Returns/accepts GATT kernel virtual address. */ > -- > 2.13.6 >
Powered by blists - more mailing lists