linux-kernel - Re: [PATCH 3/3] scripts/gdb: Add $lx_clk_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <155604339005.15276.3433915905558978655@swboyd.mtv.corp.google.com>
Date:   Tue, 23 Apr 2019 11:16:30 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Leonard Crestez <leonard.crestez@....com>
Cc:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 3/3] scripts/gdb: Add $lx_clk_core_lookup function

Quoting Leonard Crestez (2019-04-23 04:12:49)
> On 4/22/2019 11:18 PM, Stephen Boyd wrote:
> > Do you need to do the .string() for comparison? Or does it work just as
> > well to compare a gdb.Value object to a python string? It would be nice
> > if the gdb.Value object could figure out that they're not both gdb.Value
> > objects so it can do a string comparison itself.
> 
> The gdb manual is not clear on how comparisons work on gdb.Value types. 
> Converting to a python string and comparing in python work well, using 
> == on string gdb.Values results in this:
> 
>      gdb.error: evaluation of this expression requires the program to 
> have a function "malloc"
> 
> My guess is gdb attempts to convert both arguments to gdb.Value and do 
> the comparison via a call on the target? This is very undesirable here.
> 
> I get the same error if "name" is a gdb.Value instead of being converted 
> to a string in invoke().
> 

Ok. Thanks for checking. It might be worth filing a bug with gdb to see
if this can be improved in the future.