lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Apr 2019 11:16:52 -0700 From: Matthias Kaehlcke <mka@...omium.org> To: Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com> Cc: linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, Balakrishna Godavarthi <bgodavar@...eaurora.org>, Hemantg <hemantg@...eaurora.org>, Rocky Liao <rjliao@...eaurora.org>, Matthias Kaehlcke <mka@...omium.org> Subject: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that the HCI is always associated with a serdev device. This isn't true for ROME controllers instantiated through ldisc, where the call causes a crash due to a NULL pointer dereferentiation. Only call the function when we have a serdev device. The timeout for ROME devices at the end of qca_set_baudrate() is long enough to be reasonably sure that the command was sent. Fixes: fa9ad876b8e0 ("Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990") Reported-by: Balakrishna Godavarthi <bgodavar@...eaurora.org> Reported-by: Rocky Liao <rjliao@...eaurora.org> Signed-off-by: Matthias Kaehlcke <mka@...omium.org> Reviewed-by: Rocky Liao <rjliao@...eaurora.org> Tested-by: Rocky Liao <rjliao@...eaurora.org> Reviewed-by: Balakrishna Godavarthi <bgodavar@...eaurora.org> --- Changes in v2: - first version got corrupted for some reason, this should apply - added 'Reviewed-by' tags from Rocky abd Balakrishna - added 'Tested-by' tag from Rocky --- drivers/bluetooth/hci_qca.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index a80c3bc90904..7f75652686fe 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1006,7 +1006,8 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) while (!skb_queue_empty(&qca->txq)) usleep_range(100, 200); - serdev_device_wait_until_sent(hu->serdev, + if (hu->serdev) + serdev_device_wait_until_sent(hu->serdev, msecs_to_jiffies(CMD_TRANS_TIMEOUT_MS)); /* Give the controller time to process the request */ -- 2.21.0.593.g511ec345e18-goog
Powered by blists - more mailing lists