linux-kernel - Re: [PATCH AUTOSEL 4.14 35/43] tty: fix NULL pointer issue when tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 07:35:36 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Fabien Dessenne <fabien.dessenne@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH AUTOSEL 4.14 35/43] tty: fix NULL pointer issue when
 tty_port ops is not set

Hi Sasha,

On Mon, Apr 22, 2019 at 03:47:19PM -0400, Sasha Levin wrote:
> From: Fabien Dessenne <fabien.dessenne@...com>
> 
> [ Upstream commit f4e68d58cf2b20a581759bbc7228052534652673 ]
> 
> Unlike 'client_ops' which is initialized to 'default_client_ops', the
> port operations 'ops' may be left to NULL.
> Check the 'ops' value before checking the 'ops->x' value.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin (Microsoft) <sashal@...nel.org>

Despite the commit message, this one doesn't really fix anything and has
been reverted in Greg's tree (not sure why hasn't shown up in linux-next
yet).

Johan