lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACRpkdYV5cYUs21xCDMhMm=kUpFcOipE+3dZOEJYto2-w=8NtQ@mail.gmail.com> Date: Tue, 23 Apr 2019 12:59:13 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Matthias Brugger <matthias.bgg@...il.com> Cc: Zhiyong Tao <zhiyong.tao@...iatek.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Sean Wang <sean.wang@...nel.org>, srv_heupstream@...iatek.com, hui.liu@...iatek.com, huang eddie <eddie.huang@...iatek.com>, chuanjia.liu@...iatek.com, Biao Huang <biao.huang@...iatek.com>, Hongzhou Yang <hongzhou.yang@...iatek.com>, Erin Lo <erin.lo@...iatek.com>, Sean Wang <sean.wang@...iatek.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org> Subject: Re: [PATCH RESEND v3 4/4] pinctrl: add drive for I2C related pins on MT8183 On Tue, Apr 16, 2019 at 10:08 AM Matthias Brugger <matthias.bgg@...il.com> wrote: > On 25/03/2019 13:41, Zhiyong Tao wrote: > > This patch provides the advanced drive for I2C used pins on MT8183. > > The detail strength specification description of the I2C pin: > > When E1=0/E0=0, the strength is 0.125mA. > > When E1=0/E0=1, the strength is 0.25mA. > > When E1=1/E0=0, the strength is 0.5mA. > > When E1=1/E0=1, the strength is 1mA. > > For I2C pins, there are existing generic driving setup and the above > > specific driving setup. I2C pins can only support 2/4/6/8/10/12/14/16mA > > driving adjustment in generic driving setup. But in specific driving > > setup, they can support 0.125/0.25/0.5/1mA adjustment. > > If we enable specific driving setup for I2C pins, > > the existing generic driving setup will be disabled. > > For some special features, we need the I2C pins specific driving setup. > > The specific driving setup is controlled by E1E0EN. > > So we need add extra vendor driving preperty instead of the generic > > driving property. We can add "mediatek,drive-strength-adv = <XXX>;" > > to describe the specific driving setup property. > > "XXX" means the value of E1E0EN. So the valid arguments of > > "mediatek,drive-strength-adv" are from 0 to 7. > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com> > > --- > > drivers/pinctrl/mediatek/pinctrl-mt8183.c | 50 ++++++++++++++++++++++++ > > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 47 ++++++++++++++++++++++ > > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 11 ++++++ > > drivers/pinctrl/mediatek/pinctrl-paris.c | 12 ++++++ > > 4 files changed, 120 insertions(+) > > > > Linus, did that fall through the cracks? Do you have any comments on this driver? It's applied AFAICT. Maybe I forgot to push the branch, but its there. Please confirm so I didn't miss anything! Linus Walleij
Powered by blists - more mailing lists