linux-kernel - Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages

Open Source and information security mailing list archives

Message-ID: <CA+M3ks6RZmXjCh_r5MBLGeNb4vY4g8nOCX=cSbCe8GW4rHc4gQ@mail.gmail.com>
Date:   Wed, 24 Apr 2019 14:26:03 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Philippe CORNU <philippe.cornu@...com>
Cc:     Yannick FERTRE <yannick.fertre@...com>,
        Vincent ABRIOU <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages

Le lun. 1 avr. 2019 à 11:20, Philippe CORNU <philippe.cornu@...com> a écrit :
>
> Dear Yannick,
> Fully agree with this approach,
>
> Acked-by: Philippe Cornu <philippe.cornu@...com>
>

Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :-)
>
> On 3/29/19 4:49 PM, Yannick Fertré wrote:
> > From: Philippe Cornu <philippe.cornu@...com>
> >
> > Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
> > inform the user in case of fifo underruns or
> > transfer errors.
> >
> > Signed-off-by: Philippe Cornu <philippe.cornu@...com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..15d8a02 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
> >
> >       mutex_lock(&ldev->err_lock);
> >       if (ldev->error_status & ISR_FUIF) {
> > -             DRM_DEBUG_DRIVER("Fifo underrun\n");
> > +             DRM_WARN("ltdc fifo underrun: please verify display mode\n");
> >               ldev->error_status &= ~ISR_FUIF;
> >       }
> >       if (ldev->error_status & ISR_TERRIF) {
> > -             DRM_DEBUG_DRIVER("Transfer error\n");
> > +             DRM_WARN("ltdc transfer error\n");
> >               ldev->error_status &= ~ISR_TERRIF;
> >       }
> >       mutex_unlock(&ldev->err_lock);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives