linux-kernel - Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190426062844.09ae86e2@canb.auug.org.au>
Date:   Fri, 26 Apr 2019 06:28:53 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs

Hi Greg,

On Thu, 25 Apr 2019 19:46:15 +0200 Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Apr 16, 2019 at 06:03:58PM +0900, Jason A. Donenfeld wrote:
> > On Tue, Apr 16, 2019 at 4:27 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:  
> > >
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are expecting to fall through.
> > >
> > > This patch aims to suppress up to 18 missing-break-in-switch false
> > > positives on some architectures.
> > >
> > > Cc: Jason A. Donenfeld <Jason@...c4.com>
> > > Cc: Gustavo A. R. Silva <gustavo@...eddedor.com>
> > > Cc: Kees Cook <keescook@...omium.org>
> > > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>  
> > 
> > Looks good to me, thanks for this.
> > 
> > Reviewed-by: Jason A. Donenfeld <Jason@...c4.com>
> > 
> > Perhaps Greg can take it through his tree?  
> 
> Me?  Ok, fine, I'll go queue it up...

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped