linux-kernel - Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b165a9b7-8837-b5d9-6fa9-1e12f5c25ff7@embeddedor.com>
Date:   Thu, 25 Apr 2019 13:03:35 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Kees Cook <keescook@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs



On 4/25/19 12:46 PM, Greg Kroah-Hartman wrote:
> On Tue, Apr 16, 2019 at 06:03:58PM +0900, Jason A. Donenfeld wrote:
>> On Tue, Apr 16, 2019 at 4:27 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>>>
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>>> where we are expecting to fall through.
>>>
>>> This patch aims to suppress up to 18 missing-break-in-switch false
>>> positives on some architectures.
>>>
>>> Cc: Jason A. Donenfeld <Jason@...c4.com>
>>> Cc: Gustavo A. R. Silva <gustavo@...eddedor.com>
>>> Cc: Kees Cook <keescook@...omium.org>
>>> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
>>
>> Looks good to me, thanks for this.
>>
>> Reviewed-by: Jason A. Donenfeld <Jason@...c4.com>
>>
>> Perhaps Greg can take it through his tree?
> 
> Me?  Ok, fine, I'll go queue it up...
> 

Thanks, Greg.
--
Gustavo