linux-kernel - Re: [PATCH 24/30] mfd: cros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f04768c8-c87c-a076-c279-e6de63fd41e3@collabora.com>
Date:   Thu, 25 Apr 2019 10:50:06 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Gwendal Grignou <gwendal@...omium.org>, bleung@...omium.org,
        groeck@...omium.org, lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 24/30] mfd: cros_ec: Update I2S API

Hi Gwendal,

On 25/4/19 1:29, Gwendal Grignou wrote:
> Improve I2S API.
> 
> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> ---
>  include/linux/mfd/cros_ec_commands.h | 44 +++++++++++++---------------
>  1 file changed, 20 insertions(+), 24 deletions(-)
> 

[snip]

>  
> -/*
> - * For subcommand EC_CODEC_GET_GAIN.
> - */
> -struct ec_response_codec_gain {
> -	uint8_t left;
> -	uint8_t right;
> -} __ec_align1;

You should probably also update sound/soc/codecs/cros_ec_codec.c to the new
struct name in this patch, otherwise we'll get a compiler error.


>  
>  /*****************************************************************************/
>  /* System commands */
> 

Thanks,
 Enric