linux-kernel - Re: [PATCH 00/30] Update cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa1c0ab7-6491-69a8-936c-26460b78d6c2@collabora.com>
Date:   Thu, 25 Apr 2019 13:19:44 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Gwendal Grignou <gwendal@...omium.org>
Cc:     bleung@...omium.org, groeck@...omium.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/30] Update cros_ec_commands.h

Hi Gwendal, Lee

On 25/4/19 10:12, Lee Jones wrote:
> On Wed, 24 Apr 2019, Gwendal Grignou wrote:
> 
>> The interface between CrosEC embedded controller and the host,
>> described by cros_ec_commands.h, as diverged from what the embedded
>> controller really support.
>>
>> The source of thruth is at
>> https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
>>
>> That include file is converted to remove ACPI and Embedded only code.
>>
>> From now on, cros_ec_commands.h will be automatically generated from
>> the file above, do not modify directly.
>>
>> Fell free to squash the commits below.
> 
> This is going to need a bunch of Chromium reviews (and testing
> ideally) before I can take this set.
> 

I tested this patchset in different ways. With the full series applied I checked
that didn't break any cros-ec driver on Kevin, Samus and Veyron devices. I also
checked via userspace tool that I don't see any problem sending commands and
finally I checked that applying one-by-one the patches didn't break the build on
x86 and arm64, there is though, a problem,

[PATCH 24/30] mfd: cros_ec: Update I2S API

introduces a build problem because removes a struct that is currently used by
the cros_ec_codec driver. I think that at the same time we should update that
driver with the new struct name.

Once this is fixed,

Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

for the full series.

Thanks,
 Enric