linux-kernel - Re: [PATCH 4/7] net: stmmac: introducing support for DWC xPCS logics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190425032120.GJ3371@lunn.ch>
Date:   Thu, 25 Apr 2019 05:21:20 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Ong, Boon Leong" <boon.leong.ong@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>
Subject: Re: [PATCH 4/7] net: stmmac: introducing support for DWC xPCS logics

> >> +/* MII MMD AN Status defines for C37 AN SGMII Status */
> >> +#define AN_STAT_C37_AN_CMPLT		BIT(0)	/* AN Complete Intr */
> >> +#define AN_STAT_C37_AN_FD		BIT(1)	/* Full Duplex */
> >> +#define AN_STAT_C37_AN_SPEED_SHIFT	2	/* AN Speed shift */
> >> +#define AN_STAT_C37_AN_SPEED		GENMASK(3, 2)	/* AN Speed */
> >> +#define AN_STAT_C37_AN_10MBPS		0x0	/* 10 Mbps */
> >> +#define AN_STAT_C37_AN_100MBPS		0x1	/* 100 Mbps
> >*/
> >> +#define AN_STAT_C37_AN_1000MBPS		0x2	/* 1000 Mbps
> >*/
> >> +#define AN_STAT_C37_AN_LNKSTS		BIT(4)	/* Link Status */
> >
> >Is these are standardized, not proprietary, consider adding them to
> >include/uapi/linux/mii.h so similar.
> 
> Yeah, it does look very standardized. However, per DW spec, they are
> vendor-specific register set which uses MDIO_MMD_VEND2 to access.

Maybe you can go get the 802.3 standard and check section 37. If these
registers are the same, they could still be placed in mii.h. What MMD
you use is a different matter.

  Andrew