linux-kernel - Re: [PATCH] drivers/char/random.c: Make add_hwgenerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMwgTV7k=32sSFYp38Ft8M-oXhcEqcOByO=fpUBMeS1_XvzN1g@mail.gmail.com>
Date:   Sat, 27 Apr 2019 00:52:25 +0530
From:   Bharath Veda <linux.bhar@...il.com>
To:     tytso@....edu, arnd@...db.de, Greg KH <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/char/random.c: Make add_hwgenerator_randomness static

Hi,

Please ignore this patch. It breaks the build.

Thank you

On Fri, Apr 26, 2019 at 11:59 PM Bharath Vedartham <linux.bhar@...il.com> wrote:
>
> Make add_hwgenerator_randomness static as it is only declared on
> drivers/char/random.c
>
> Signed-off-by: Bharath Vedartham <linux.bhar@...il.com>
> ---
>  drivers/char/random.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 38c6d1a..08fd00a 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -2342,7 +2342,7 @@ randomize_page(unsigned long start, unsigned long range)
>   * Those devices may produce endless random bits and will be throttled
>   * when our pool is full.
>   */
> -void add_hwgenerator_randomness(const char *buffer, size_t count,
> +static void add_hwgenerator_randomness(const char *buffer, size_t count,
>                                 size_t entropy)
>  {
>         struct entropy_store *poolp = &input_pool;
> --
> 2.7.4
>