linux-kernel - Re: [PATCH] drivers/char/random.c: Make add_hwgenerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190426200617.GF9835@mit.edu>
Date:   Fri, 26 Apr 2019 16:06:17 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Bharath Veda <linux.bhar@...il.com>
Cc:     arnd@...db.de, Greg KH <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/char/random.c: Make add_hwgenerator_randomness
 static

On Sat, Apr 27, 2019 at 12:52:25AM +0530, Bharath Veda wrote:
> Hi,
> 
> Please ignore this patch. It breaks the build.
> 
> On Fri, Apr 26, 2019 at 11:59 PM Bharath Vedartham <linux.bhar@...il.com> wrote:
> >
> > Make add_hwgenerator_randomness static as it is only declared on
> > drivers/char/random.c

If one were to run the handy-dandy command "git grep
add_hwgenerator_randomness", one would find:

drivers/char/hw_random/core.c:          add_hwgenerator_randomness((void *)rng_fillbuf, rc,
drivers/char/random.c:void add_hwgenerator_randomness(const char *buffer, size_t count,
drivers/char/random.c:EXPORT_SYMBOL_GPL(add_hwgenerator_randomness);
drivers/net/wireless/ath/ath9k/rng.c:           add_hwgenerator_randomness((void *)rng_buf, bytes_read,
include/linux/hw_random.h:extern void add_hwgenerator_randomness(const char *buffer, size_t count, size_t entropy);

So the claim that it is only declared in drivers/char/random.c is not
true.

And of course, build-testing patches before sending them out for
review is a really good idea.

Cheers,

    	 	      	  	 	     	- Ted