linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Make USB1 peripheral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 13:26:34 -0600
From:   Jeffrey Hugo <jeffrey.l.hugo@...il.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Make USB1 peripheral

On Fri, Apr 26, 2019 at 1:10 PM Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> The MTP is a "mobile reference device", as such the default operation is
> to use fastboot to boot/flash software onto it and the common case is
> thereby that we boot with a USB cable connected downstream from a PC or
> a hub.  And without support for the PMI8998 charger block VBUS will not
> be driven by the device.
>
> Switch to peripheral until we can enable OTG.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Makes sense to me.

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>

> ---
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index 02b8357c8ce8..2e78638eb73b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -404,8 +404,8 @@
>  };
>
>  &usb_1_dwc3 {
> -       /* Until we have Type C hooked up we'll force this as host. */
> -       dr_mode = "host";
> +       /* Until we have Type C hooked up we'll force this as peripheral. */
> +       dr_mode = "peripheral";
>  };
>
>  &usb_1_hsphy {
> --
> 2.18.0
>