linux-kernel - Re: [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fa39d6a-f74e-e0b7-ded9-948d1576a2b9@redhat.com>
Date:   Fri, 26 Apr 2019 11:07:42 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Pierre Morel <pmorel@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, cohuck@...hat.com,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org,
        frankja@...ux.ibm.com, akrowiak@...ux.ibm.com,
        borntraeger@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com
Subject: Re: [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB
 format

On 26.04.19 11:00, Pierre Morel wrote:
> Let's use the correct validity number.
> 
> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
> 
> Signed-off-by: Pierre Morel <pmorel@...ux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@...ibm.com>
> ---
>  arch/s390/kvm/vsie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index ac411e9..076090f 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>  end:
>  	switch (ret) {
>  	case -EINVAL:
> -		return set_validity_icpt(scb_s, 0x0020U);
> +		return set_validity_icpt(scb_s, 0x0022U);
>  	case -EFAULT:
>  		return set_validity_icpt(scb_s, 0x0035U);
>  	case -EACCES:
> 

Can't verify

Acked-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb