linux-kernel - Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2816348.laE8LpYbrI@phil>
Date:   Sun, 28 Apr 2019 12:40:08 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Wen Yang <wen.yang99@....com.cn>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
        Yi Wang <wang.yi59@....com.cn>
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions

Am Sonntag, 28. April 2019, 08:27:05 CEST schrieb Markus Elfring:
> >  arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++--
> >  arch/arm/mach-rockchip/pm.c      |  2 ++
> 
> * Would a commit subject variant be nicer?

yeah, but I'll simply adjust that when applying.

> * I dare to present a reminder for a recurring development topic.
>   How do you think about to adjust the exception handling in these function
>   implementations a bit more according to the Linux coding style
>   (so that the addition of duplicate function calls would be avoided)?

I actually requested not doing wild gotos for of_node_put calls,
as it makes the code harder to read, especially when the "node"
gets reused for a different node-source.