linux-kernel - Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cee2ab03-d0b7-c9c6-acc3-d5aa28979e2b@web.de>
Date:   Sun, 28 Apr 2019 08:27:05 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wen Yang <wen.yang99@....com.cn>,
        Heiko Stübner <heiko@...ech.de>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
        Yi Wang <wang.yi59@....com.cn>
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding
 of_node_put() in two functions

>  arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++--
>  arch/arm/mach-rockchip/pm.c      |  2 ++

* Would a commit subject variant be nicer?

* I dare to present a reminder for a recurring development topic.
  How do you think about to adjust the exception handling in these function
  implementations a bit more according to the Linux coding style
  (so that the addition of duplicate function calls would be avoided)?

Regards,
Markus