linux-kernel - Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHQ1cqExxTYtkmHyL7cCQMjnX+6B0jC7VmtX4w+8tZNShDGj2g@mail.gmail.com>
Date:   Sun, 28 Apr 2019 15:24:39 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     Linux PM list <linux-pm@...r.kernel.org>,
        Chris Health <cphealy@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Guenter Roeck <linux@...ck-us.net>,
        Sebastian Reichel <sre@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002

On Fri, Apr 26, 2019 at 7:43 AM Lucas Stach <l.stach@...gutronix.de> wrote:
>
> Hi Andrey,
>
> Am Mittwoch, den 17.04.2019, 01:44 -0700 schrieb Andrey Smirnov:
> > Add driver for Microchip UCS1002 Programmable USB Port Power
> > Controller with Charger Emulation. The driver exposed a power supply
> > device to control/monitor various parameter of the device as well as a
> > regulator to allow controlling VBUS line.
> >
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > > Cc: Chris Health <cphealy@...il.com>
> > > Cc: Lucas Stach <l.stach@...gutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@....com>
> > > Cc: Guenter Roeck <linux@...ck-us.net>
> > > Cc: Sebastian Reichel <sre@...nel.org>
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-pm@...r.kernel.org
> > ---
> [...]
> > +     if (irq_a_det > 0) {
> > > +           ret = devm_request_threaded_irq(dev, irq_a_det, NULL,
> > > +                                           ucs1002_charger_irq,
> > > +                                           IRQF_TRIGGER_FALLING |
> > > +                                           IRQF_TRIGGER_RISING |
> > > +                                           IRQF_ONESHOT,
> > > +                                           "ucs1002-a_det", info);
> > > +           if (ret) {
> > > +                   dev_err(dev, "failed to request A_DET threaded irq\n");
> > > +                   return ret;
> > > +           }
> > > +   }
> > +
> > > +   if (irq_alert > 0) {
> > > +           ret = devm_request_threaded_irq(dev, irq_alert, NULL,
> > > +                                           ucs1002_alert_irq,
> > > +                                           IRQF_TRIGGER_FALLING |
> > > +                                           IRQF_TRIGGER_RISING |
> > > +                                           IRQF_ONESHOT,
> > > +                                           "ucs1002-alert", info);
> > > +           if (ret) {
> > > +                   dev_err(dev, "failed to request ALERT threaded irq\n");
> > > +                   return ret;
> > > +           }
> > > +   }
>
> Any reason to explicitly set the IRQ trigger type here? Normally I
> would expect this to be set via the DT interrupt specifier.
>

Don't have a particular reason. I'll move it to DT.

Thanks,
Andrey Smirnov