linux-kernel - Re: [PATCH] nvmet: fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR04MB45271D793C898E527914578086390@SN6PR04MB4527.namprd04.prod.outlook.com>
Date:   Mon, 29 Apr 2019 22:14:15 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Minwoo Im <minwoo.im.dev@...il.com>
CC:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings

Hi Minwoo,

Can you please resend this patch with the suggested change ?

On 04/29/2019 10:58 AM, kbuild test robot wrote:
> From: kbuild test robot <lkp@...el.com>
>
> drivers/nvme/target/discovery.c:375:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
>   Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: 6b7e631b927c ("nvmet: return a specified error it subsys_alloc fails")
> CC: Minwoo Im <minwoo.im.dev@...il.com>
> Signed-off-by: kbuild test robot <lkp@...el.com>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   3d17a1de96a233cf89bfbb5a77ebb1a05c420681
> commit: 6b7e631b927ca1266b2695307ab71ed7764af75e [9188/10649] nvmet: return a specified error it subsys_alloc fails
>
>   discovery.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- a/drivers/nvme/target/discovery.c
> +++ b/drivers/nvme/target/discovery.c
> @@ -372,9 +372,7 @@ int __init nvmet_init_discovery(void)
>   {
>   	nvmet_disc_subsys =
>   		nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME, NVME_NQN_DISC);
> -	if (IS_ERR(nvmet_disc_subsys))
> -		return PTR_ERR(nvmet_disc_subsys);
> -	return 0;
> +	return PTR_ERR_OR_ZERO(nvmet_disc_subsys);
>   }
>
>   void nvmet_exit_discovery(void)
>