linux-kernel - RE: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings

Open Source and information security mailing list archives

Message-ID: <20190429224031epcms2p45b9198075ea9406da495a1b813400a0d@epcms2p4>
Date:   Tue, 30 Apr 2019 07:40:31 +0900
From:   Minwoo Im <minwoo.im@...sung.com>
To:     Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>,
        Minwoo Im <minwoo.im.dev@...il.com>,
        Minwoo Im <minwoo.im@...sung.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        Sagi Grimberg <sagi@...mberg.me>
Subject: RE: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings

Sure, I will.

Thanks,

> -----Original Message-----
> From: Linux-nvme [mailto:linux-nvme-bounces@...ts.infradead.org] On
> Behalf Of Chaitanya Kulkarni
> Sent: Tuesday, April 30, 2019 7:14 AM
> To: Minwoo Im
> Cc: linux-kernel@...r.kernel.org; Christoph Hellwig; linux-
> nvme@...ts.infradead.org; Sagi Grimberg
> Subject: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings
> 
> Hi Minwoo,
> 
> Can you please resend this patch with the suggested change ?
> 
> On 04/29/2019 10:58 AM, kbuild test robot wrote:
> > From: kbuild test robot <lkp@...el.com>
> >
> > drivers/nvme/target/discovery.c:375:1-3: WARNING: PTR_ERR_OR_ZERO
> can be used
> >
> >
> >   Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Fixes: 6b7e631b927c ("nvmet: return a specified error it subsys_alloc fails")
> > CC: Minwoo Im <minwoo.im.dev@...il.com>
> > Signed-off-by: kbuild test robot <lkp@...el.com>
> > ---
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> > head:   3d17a1de96a233cf89bfbb5a77ebb1a05c420681
> > commit: 6b7e631b927ca1266b2695307ab71ed7764af75e [9188/10649]
> nvmet: return a specified error it subsys_alloc fails
> >
> >   discovery.c |    4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > --- a/drivers/nvme/target/discovery.c
> > +++ b/drivers/nvme/target/discovery.c
> > @@ -372,9 +372,7 @@ int __init nvmet_init_discovery(void)
> >   {
> >   	nvmet_disc_subsys =
> >   		nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME,
> NVME_NQN_DISC);
> > -	if (IS_ERR(nvmet_disc_subsys))
> > -		return PTR_ERR(nvmet_disc_subsys);
> > -	return 0;
> > +	return PTR_ERR_OR_ZERO(nvmet_disc_subsys);
> >   }
> >
> >   void nvmet_exit_discovery(void)
> >
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives