linux-kernel - Re: [PATCH -next] lib/vsprintf: Make function pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190429091320.019e726b@gandalf.local.home>
Date:   Mon, 29 Apr 2019 09:13:20 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Yue Haibing <yuehaibing@...wei.com>, sergey.senozhatsky@...il.com,
        andriy.shevchenko@...ux.intel.com, geert+renesas@...der.be,
        me@...in.cc, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

On Mon, 29 Apr 2019 13:08:01 +0200
Petr Mladek <pmladek@...e.com> wrote:

> > Looks like commit "vsprintf: Do not check address of well-known
> > strings" removed the: "static noinline_for_stack"
> > 
> > Does pointer_string() need that still?  
> 
> Heh, it was removed by mistake and well hidden in the diff.
> 
> I have pushed Yue's fix into printk.git, branch
> for-5.2-vsprintf-hardening
> 
> Thanks for the patch.

But doesn't it still need the "noinline_for_stack", that doesn't look
like it changed.

-- Steve