linux-kernel - Re: [PATCH -next] lib/vsprintf: Make function pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Apr 2019 13:08:01 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Yue Haibing <yuehaibing@...wei.com>, sergey.senozhatsky@...il.com,
        andriy.shevchenko@...ux.intel.com, geert+renesas@...der.be,
        me@...in.cc, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

On Fri 2019-04-26 13:02:04, Steven Rostedt wrote:
> On Sat, 27 Apr 2019 00:46:30 +0800
> Yue Haibing <yuehaibing@...wei.com> wrote:
> 
> > From: YueHaibing <yuehaibing@...wei.com>
> > 
> > Fix sparse warning:
> > 
> > lib/vsprintf.c:673:6: warning:
> >  symbol 'pointer_string' was not declared. Should it be static?
> > 
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  lib/vsprintf.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > index 1f367f3..7b0a614 100644
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -670,8 +670,9 @@ char *string(char *buf, char *end, const char *s,
> >  	return string_nocheck(buf, end, s, spec);
> >  }
> >  
> > -char *pointer_string(char *buf, char *end, const void *ptr,
> > -		     struct printf_spec spec)
> > +static char *pointer_string(char *buf, char *end,
> 
> Looks like commit "vsprintf: Do not check address of well-known
> strings" removed the: "static noinline_for_stack"
> 
> Does pointer_string() need that still?

Heh, it was removed by mistake and well hidden in the diff.

I have pushed Yue's fix into printk.git, branch
for-5.2-vsprintf-hardening

Thanks for the patch.

Best Regards,
Petr