linux-kernel - Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Apr 2019 17:35:55 +0200
From:   Alexey Gladkov <gladkov.alexey@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        linux-api@...r.kernel.org, linux-modules@...r.kernel.org,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Jessica Yu <jeyu@...nel.org>,
        Lucas De Marchi <lucas.de.marchi@...il.com>
Subject: Re: [PATCH v3] moduleparam: Save information about built-in modules
 in separate file

On Tue, Apr 30, 2019 at 12:08:44AM +0900, Masahiro Yamada wrote:
> >  modules.builtin
> > +modules.builtin.modinfo
> >
> >  #
> >  # Top-level generic files
> 
> 
> Let me repeat the same comments as in v2
> (https://patchwork.kernel.org/patch/10888207/#22595563)
> as you ignored them.

I miss it. Sorry about that.

> > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> > index c8cf45362bd6..41ef7cb043c1 100755
> > --- a/scripts/link-vmlinux.sh
> > +++ b/scripts/link-vmlinux.sh
> > @@ -226,6 +226,10 @@ modpost_link vmlinux.o
> >  # modpost vmlinux.o to check for section mismatches
> >  ${MAKE} -f "${srctree}/scripts/Makefile.modpost" vmlinux.o
> >
> > +info MODINFO modules.builtin.modinfo
> > +"${OBJCOPY}" -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
> > +chmod 444 modules.builtin.modinfo
> 
> 
> Why is this 'chmod 444' necessary?

I just wanted to show that this file will never change.
I will remove this line.

-- 
Rgrds, legion