linux-kernel - RE: [PATCH 3/7] net: stmmac: dma channel control register need to be init first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D6759987A7968C4889FDA6FA91D5CBC8146F0B78@PGSMSX103.gar.corp.intel.com>
Date:   Tue, 30 Apr 2019 02:49:16 +0000
From:   "Voon, Weifeng" <weifeng.voon@...el.com>
To:     Jose Abreu <Jose.Abreu@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "Andrew Lunn" <andrew@...n.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "Giuseppe Cavallaro" <peppe.cavallaro@...com>
Subject: RE: [PATCH 3/7] net: stmmac: dma channel control register need to
 be init first

> From: Voon, Weifeng <weifeng.voon@...el.com>
> Date: Thu, Apr 25, 2019 at 08:06:08
> 
> > > stmmac_init_chan() needs to be called before stmmac_init_rx_chan()
> > > and stmmac_init_tx_chan(). This is because if PBLx8 is to be used,
> > > "DMA_CH(#i)_Control.PBLx8" needs to be set before programming
> > > "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL".
> > >
> > > Reviewed-by: Zhang, Baoli <baoli.zhang@...el.com>
> > > Signed-off-by: Weifeng Voon <weifeng.voon@...el.com>
> > > Signed-off-by: Ong Boon Leong <boon.leong.ong@...el.com>
> 
> This is a fix so it should belong to -net tree and it should have the
> "Fixes: " tag.
> 
> Thanks,
> Jose Miguel Abreu

Noted. I will add the "Fixes" tag and re-submit to -net tree. 

Regards,
Weifeng