linux-kernel - Re: [PATCH 1/2] blkdev.h: Introduce size_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Apr 2019 22:50:32 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:     linux-block@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Hannes Reinecke <hare@...e.com>,
        Omar Sandoval <osandov@...com>, Ming Lei <ming.lei@...hat.com>,
        Damien Le Moal <damien.lemoal@....com>,
        Bart Van Assche <bvanassche@....org>,
        Greg Edwards <gedwards@....com>,
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 1/2] blkdev.h: Introduce size_to_sectors hlper function


Hi Marco,

> +static inline sector_t size_to_sectors(long long size)
> +{
> +	return size >> SECTOR_SHIFT;
> +}
> +

FWIW, in SCSI we have:

	logical_to_sectors()
        logical_to_bytes()
        bytes_to_logical()
        sectors_to_logical()

I'm not attached to "bytes" in any way but it would be nice to be
consistent.

-- 
Martin K. Petersen	Oracle Linux Engineering