linux-kernel - RE: [PATCH] clk: imx: pllv3: Fix fall through build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916F59134DB9CF9837B43C1F53B0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Wed, 1 May 2019 09:33:46 +0000
From:   Anson Huang <anson.huang@....com>
To:     Stephen Boyd <sboyd@...nel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] clk: imx: pllv3: Fix fall through build warning

Hi, Stephen
	I saw Gustavo already sent out a patch to fix these two warnings, so I will NOT sent the patch again, thanks.

> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@...nel.org]
> Sent: Wednesday, May 1, 2019 2:17 AM
> To: festevam@...il.com; kernel@...gutronix.de; linux-arm-
> kernel@...ts.infradead.org; linux-clk@...r.kernel.org; linux-
> kernel@...r.kernel.org; mturquette@...libre.com;
> s.hauer@...gutronix.de; shawnguo@...nel.org; Anson Huang
> <anson.huang@....com>; Gustavo A. R. Silva <gustavo@...eddedor.com>
> Cc: dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH] clk: imx: pllv3: Fix fall through build warning
> 
> Quoting Anson Huang (2019-04-29 18:55:18)
> > Fix below fall through build warning:
> >
> > drivers/clk/imx/clk-pllv3.c:453:21: warning:
> > this statement may fall through [-Wimplicit-fallthrough=]
> >
> >    pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> >                      ^
> > drivers/clk/imx/clk-pllv3.c:454:2: note: here
> >   case IMX_PLLV3_AV:
> >   ^~~~
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> 
> Gustavo says there are two warnings. Please compile test with the right
> options, add Reported-by tags when you get bug reports from someone, and
> add a Fixes tag and then resend.
> 
> >  drivers/clk/imx/clk-pllv3.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> > index e892b9a..fbe4fe0 100644
> > --- a/drivers/clk/imx/clk-pllv3.c
> > +++ b/drivers/clk/imx/clk-pllv3.c
> > @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type,
> const char *name,
> >         case IMX_PLLV3_AV_IMX7:
> >                 pll->num_offset = PLL_IMX7_NUM_OFFSET;
> >                 pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> > +               /* fall through */
> >         case IMX_PLLV3_AV:
> >                 ops = &clk_pllv3_av_ops;
> >                 break;