linux-kernel - Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 May 2019 22:20:44 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     Nishad Kamdar <nishadkamdar@...il.com>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-actions@...ts.infradead.org
Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License
 Identifier

+ linux-actions

Am 01.05.19 um 09:07 schrieb Nishad Kamdar:
> This patch corrects the SPDX License Identifier style
> in header files related to Clock Drivers for Actions Semi Socs.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
[...]
>  drivers/clk/actions/owl-common.h       | 2 +-
>  drivers/clk/actions/owl-composite.h    | 2 +-
>  drivers/clk/actions/owl-divider.h      | 2 +-
>  drivers/clk/actions/owl-factor.h       | 2 +-
>  drivers/clk/actions/owl-fixed-factor.h | 2 +-
>  drivers/clk/actions/owl-gate.h         | 2 +-
>  drivers/clk/actions/owl-mux.h          | 2 +-
>  drivers/clk/actions/owl-pll.h          | 2 +-
>  drivers/clk/actions/owl-reset.h        | 2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)

Where's the practical benefit of this patch? These are all private
headers used from C files, so they can handle C++ comments just fine,
otherwise we would've seen build failures.

I could understand if you were patching files in include/ but not here.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)