lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190502172345.GC1874@kroah.com> Date: Thu, 2 May 2019 19:23:45 +0200 From: Greg KH <gregkh@...uxfoundation.org> To: Dragan Cvetic <dragan.cvetic@...inx.com> Cc: arnd@...db.de, michal.simek@...inx.com, linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org, mark.rutland@....com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Derek Kiernan <derek.kiernan@...inx.com> Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote: > Add char device interface per DT node present and support > file operations: > - open(), > - close(), > - unlocked_ioctl(), > - compat_ioctl(). Why do you need compat_ioctl() at all? Any "new" driver should never need it. Just create your structures properly. thanks, greg k-h
Powered by blists - more mailing lists