lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190502172713.GD1874@kroah.com> Date: Thu, 2 May 2019 19:27:13 +0200 From: Greg KH <gregkh@...uxfoundation.org> To: Dragan Cvetic <dragan.cvetic@...inx.com> Cc: arnd@...db.de, michal.simek@...inx.com, linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org, mark.rutland@....com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Derek Kiernan <derek.kiernan@...inx.com> Subject: Re: [PATCH V3 07/12] misc: xilinx_sdfec: Add ability to configure LDPC On Sat, Apr 27, 2019 at 11:05:01PM +0100, Dragan Cvetic wrote: > --- a/include/uapi/misc/xilinx_sdfec.h > +++ b/include/uapi/misc/xilinx_sdfec.h <snip> > +/** > + * xsdfec_calculate_shared_ldpc_table_entry_size - Calculates shared code > + * table sizes. > + * @ldpc: Pointer to the LPDC Code Parameters > + * @table_sizes: Pointer to structure containing the calculated table sizes > + * > + * Calculates the size of shared LDPC code tables used for a specified LPDC code > + * parameters. > + */ > +inline void > +xsdfec_calculate_shared_ldpc_table_entry_size(struct xsdfec_ldpc_params *ldpc, > + struct xsdfec_ldpc_param_table_sizes *table_sizes) > +{ > + /* Calculate the sc_size in 32 bit words */ > + table_sizes->sc_size = (ldpc->nlayers + 3) >> 2; > + /* Calculate the la_size in 256 bit words */ > + table_sizes->la_size = ((ldpc->nlayers << 2) + 15) >> 4; > + /* Calculate the qc_size in 256 bit words */ > + table_sizes->qc_size = ((ldpc->nqc << 2) + 15) >> 4; > +} Why do you have an inline function in a user api .h file? That's really not a good idea. thanks, greg k-h
Powered by blists - more mailing lists