linux-kernel - Re: [PATCH v6 3/3] backlight: lm3630a: add firmware node support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190502104612.GB24563@basecamp>
Date:   Thu, 2 May 2019 06:46:12 -0400
From:   Brian Masney <masneyb@...tation.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     lee.jones@...aro.org, jingoohan1@...il.com, robh+dt@...nel.org,
        jacek.anaszewski@...il.com, pavel@....cz, mark.rutland@....com,
        b.zolnierkie@...sung.com, dri-devel@...ts.freedesktop.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dmurphy@...com, jonathan@...ek.ca,
        Daniel Thompson <daniel@...felineninja.org.uk>
Subject: Re: [PATCH v6 3/3] backlight: lm3630a: add firmware node support

On Thu, May 02, 2019 at 11:19:50AM +0100, Daniel Thompson wrote:
> On 24/04/2019 10:25, Brian Masney wrote:
> > Add fwnode support to the lm3630a driver and optionally allow
> > configuring the label, default brightness level, and maximum brightness
> > level. The two outputs can be controlled by bank A and B independently
> > or bank A can control both outputs.
> > 
> > If the platform data was not configured, then the driver defaults to
> > enabling both banks. This patch changes the default value to disable
> > both banks before parsing the firmware node so that just a single bank
> > can be enabled if desired. There are no in-tree users of this driver.
> 
> In that case given I'd certainly entertain patches that move the config
> structures out of include/linux/platform_data and say the driver requires a
> proper entry in the hardware description! Not a requirement though.

OK, I'll submit patches for that after this series is merged.

Brian