linux-kernel - Re: [PATCH 1/2] scripts/gdb: Cleanup error handling in list helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <155690120115.200842.4461891246222331678@swboyd.mtv.corp.google.com>
Date:   Fri, 03 May 2019 09:33:21 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        Leonard Crestez <leonard.crestez@....com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Michael Turquette <mturquette@...libre.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] scripts/gdb: Cleanup error handling in list helpers

Quoting Leonard Crestez (2019-05-03 04:19:31)
> An incorrect argument to list_for_each is an internal error in gdb
> scripts so a TypeError should be raised. The gdb.GdbError exception type
> is intended for user errors such as incorrect invocation.
> 
> Drop the type assertion in list_for_each_entry because list_for_each isn't
> going to suddenly yield something else.
> 
> Applies to both list and hlist

This should be done to other "type errors" in the gdb scripts too.

> 
> Signed-off-by: Leonard Crestez <leonard.crestez@....com>
> ---

Either way,

Reviewed-by: Stephen Boyd <sboyd@...nel.org>