linux-kernel - Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 May 2019 17:55:08 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     Andrew Jeffery <andrew@...id.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Arnd Bergmann <arnd@...db.de>, Joel Stanley <joel@....id.au>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sai Dasari <sdasari@...com>
Subject: Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values



On 5/1/19, 11:49 PM, "Andrew Jeffery" <andrew@...id.au> wrote:

    
    
    On Thu, 2 May 2019, at 16:10, Greg Kroah-Hartman wrote:
    > On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote:
    > > Corrected some of return values with appropriate meanings.
    > > 
    > > Signed-off-by: Vijay Khemka <vijaykhemka@...com>
    > > ---
    > >  drivers/misc/aspeed-lpc-ctrl.c | 15 +++++++--------
    > >  1 file changed, 7 insertions(+), 8 deletions(-)
    > > 
    > > diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
    > > index 332210e06e98..97ae341109d5 100644
    > > --- a/drivers/misc/aspeed-lpc-ctrl.c
    > > +++ b/drivers/misc/aspeed-lpc-ctrl.c
    > > @@ -68,7 +68,6 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, unsigned int cmd,
    > >  		unsigned long param)
    > >  {
    > >  	struct aspeed_lpc_ctrl *lpc_ctrl = file_aspeed_lpc_ctrl(file);
    > > -	struct device *dev = file->private_data;
    > >  	void __user *p = (void __user *)param;
    > >  	struct aspeed_lpc_ctrl_mapping map;
    > >  	u32 addr;
    > 
    > This change is not reflected in your changelog text :(
    > 
    > Please fix up, or break this up into multiple patches.
    
    The return value fixes should also be squashed into the patch that introduced those lines
    given it hasn't yet been applied.
    
    Further, IIRC I previously suggested removing the dev_err()s entirely, not just switching
    them to pr_err(). Returning an error code is enough IMO, there's no need to pollute the
    kernel logs with application-level errors. Or make them dev_dbg().

Alright, I will replace with dev_dbg(), information can still be extracted by user with debug.
    
    Andrew
    
    > 
    > greg k-h
    >