lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 06 May 2019 10:55:19 +0300 From: Maxim Levitsky <mlevitsk@...hat.com> To: Keith Busch <kbusch@...nel.org> Cc: Fam Zheng <fam@...hon.net>, kvm@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>, linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org, Keith Busch <keith.busch@...el.com>, Kirti Wankhede <kwankhede@...dia.com>, Mauro Carvalho Chehab <mchehab+samsung@...nel.org>, "Paul E . McKenney" <paulmck@...ux.ibm.com>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Liang Cunming <cunming.liang@...el.com>, Jens Axboe <axboe@...com>, Alex Williamson <alex.williamson@...hat.com>, John Ferlan <jferlan@...hat.com>, Liu Changpeng <changpeng.liu@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Heitke, Kenneth" <kenneth.heitke@...el.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Paolo Bonzini <pbonzini@...hat.com>, Amnon Ilan <ailan@...hat.com>, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface On Fri, 2019-05-03 at 06:09 -0600, Keith Busch wrote: > On Fri, May 03, 2019 at 12:20:17AM +0300, Maxim Levitsky wrote: > > On Thu, 2019-05-02 at 15:12 -0600, Heitke, Kenneth wrote: > > > On 5/2/2019 5:47 AM, Maxim Levitsky wrote: > > > > +static void nvme_ext_queue_free(struct nvme_ctrl *ctrl, u16 qid) > > > > +{ > > > > + struct nvme_dev *dev = to_nvme_dev(ctrl); > > > > + struct nvme_queue *nvmeq; > > > > + > > > > + mutex_lock(&dev->ext_dev_lock); > > > > + nvmeq = &dev->queues[qid]; > > > > + > > > > + if (WARN_ON(!test_bit(NVMEQ_EXTERNAL, &nvmeq->flags))) > > > > + return; > > > > > > This condition is probably not expected to happen (since its a warning) > > > but do you need to unlock the ext_dev_lock before returning? > > > > This is true, I will fix this. This used to be BUG_ON, but due to > > checkpatch.pl > > complains I turned them all to WARN_ON, and missed this. > > Gentle reminder to trim your replies to the relevant context. It's > much easier to read when we don't need to scroll through hundreds of > unnecessary lines. I fully agree, sorry! Next time I will do this. Best regards, Maxim Levitsky
Powered by blists - more mailing lists