[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <db0b0790-4556-8a3b-2ae1-fcb4b1beb4b3@ti.com>
Date: Tue, 7 May 2019 21:57:04 +0530
From: Faiz Abbas <a0230074@...com>
To: Adrian Hunter <adrian.hunter@...el.com>,
Faiz Abbas <faiz_abbas@...com>, <linux-kernel@...r.kernel.org>,
<linux-mmc@...r.kernel.org>
CC: <ulf.hansson@...aro.org>
Subject: Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write
Hi Adrian,
On 26/04/19 11:30 AM, Adrian Hunter wrote:
> On 25/04/19 6:57 PM, Faiz Abbas wrote:
>> In the call to regmap_update_bits() for SLOTTYPE, the mask and value
>> fields are exchanged. Fix this.
>
> Could you also comment on whether this has any known effect on the driver.
>
This call was basically a NOP but it was the correct way around in
u-boot so it was just taking that value instead. No effect that was
known to me. Found this out just by inspection.
Thanks,
Faiz
Powered by blists - more mailing lists