linux-kernel - Re: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c867970-1255-b11f-9edf-ff002b7cea58@ti.com>
Date:   Tue, 7 May 2019 21:59:06 +0530
From:   Faiz Abbas <a0230074@...com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        Faiz Abbas <faiz_abbas@...com>, <linux-kernel@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>
CC:     <ulf.hansson@...aro.org>
Subject: Re: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations

Hi Adrian,

On 26/04/19 11:20 AM, Adrian Hunter wrote:
> On 25/04/19 6:57 PM, Faiz Abbas wrote:
>> Fix the following minor things:
>>
>> 1. Line wrapping with the regmap_*() functions is way more conservative
>> than required by the 80 character rule. Expand the function calls out to
>> use less number of lines.
>>
>> 2. Add an error message if the DLL fails to lock.
> 
> Please make the white space changes a separate patch.
> 
> Also I would prefer not to use "fix" in the subject unless the patch fixes
> driver behaviour.
> 

Ok. Two different patches. No "fix" in the subject. Sending v2.

Thanks,
Faiz