linux-kernel - Re: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+tmUCjZw7ybhKTGg0NNfc+JsOQ30vArfHzdw14XoWm5A@mail.gmail.com>
Date:   Tue, 7 May 2019 11:40:02 -0500
From:   Rob Herring <robh@...nel.org>
To:     Ran Wang <ran.wang_1@....com>
Cc:     Shawn Guo <shawnguo@...nel.org>, Leo Li <leoyang.li@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes

On Tue, May 7, 2019 at 3:48 AM Ran Wang <ran.wang_1@....com> wrote:
>
> Hi Rob,
>
> On Thursday, May 02, 2019 07:54 Rob Herring wrote:
> >
> > On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > > This patch adds USB dt nodes for LS1028A.
> > >
> > > Signed-off-by: Ran Wang <ran.wang_1@....com>
> > > ---
> > > Changes in v2:
> > >   - Rename node from usb3@... to usb@... to meet DTSpec
> > >
> > >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   20
> > ++++++++++++++++++++
> > >  1 files changed, 20 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index 8dd3501..188cfb8 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -144,6 +144,26 @@
> > >                     clocks = <&sysclk>;
> > >             };
> > >
> > > +           usb0:usb@...0000 {
> >                      ^ space needed
>
> Yes, will update this in next version.
>
> > > +                   compatible= "snps,dwc3";
> >
> > Needs an SoC specific compatible.
>
> Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?

Well, that's the wrong order, but yes.

> As I know, so far there is no SoC specific programming for this IP, so do
> you think it's still necessary to add it?

Yes. All the bugs and quirks are discovered already?

Rob