linux-kernel - Re: [PATCH v2] v4l: Add source event change for bit-depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190508221402.6fh5k2pvep33lggj@valkosipuli.retiisi.org.uk>
Date:   Thu, 9 May 2019 01:14:02 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        linux-media@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] v4l: Add source event change for bit-depth

On Wed, May 08, 2019 at 06:38:49PM +0200, Hans Verkuil wrote:
> On 5/8/19 5:34 PM, Stanimir Varbanov wrote:
> > Hi Hans,
> > 
> > On 5/8/19 2:37 PM, Stanimir Varbanov wrote:
> >> This event indicate that the source bit-depth is changed during
> >> run-time. The client must get the new format and re-allocate buffers
> >> for it. This can usually happens with video decoder (encoders) when
> >> the bit-stream depth is changed from 8 to 10bits or vice versa.
> >>
> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> >> ---
> >> Change since v1: s/BITDEPTH/BIT_DEPTH
> >>
> >>  Documentation/media/uapi/v4l/vidioc-dqevent.rst | 7 +++++++
> >>  Documentation/media/videodev2.h.rst.exceptions  | 1 +
> >>  include/uapi/linux/videodev2.h                  | 1 +
> >>  3 files changed, 9 insertions(+)
> >>
> >> diff --git a/Documentation/media/uapi/v4l/vidioc-dqevent.rst b/Documentation/media/uapi/v4l/vidioc-dqevent.rst
> >> index dea9c0cc00ab..f7782cbddc5f 100644
> >> --- a/Documentation/media/uapi/v4l/vidioc-dqevent.rst
> >> +++ b/Documentation/media/uapi/v4l/vidioc-dqevent.rst
> >> @@ -397,6 +397,13 @@ call.
> >>  	that many devices are not able to recover from a temporary loss of
> >>  	signal and so restarting streaming I/O is required in order for the
> >>  	hardware to synchronize to the video signal.
> >> +    * - ``V4L2_EVENT_SRC_CH_BIT_DEPTH``
> > 
> > I started to wonder isn't COLOR_DEPTH more appropriate? Bit-depth
> > doesn't describe what is actually deep.
> > 
> 
> I agree. COLOR_DEPTH is a better name.

Please add:

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus