linux-kernel - Re: [PATCH 04/10] PCI/AER: Log messages with pci_dev, not pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509214454.GE235064@google.com>
Date:   Thu, 9 May 2019 16:44:54 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Frederick Lawler <fred@...dlawl.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Keith Busch <keith.busch@...el.com>,
        Dongdong Liu <liudongdong3@...wei.com>,
        Sven Van Asbroeck <thesven73@...il.com>,
        linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/10] PCI/AER: Log messages with pci_dev, not pcie_device

On Thu, May 09, 2019 at 08:42:10PM +0300, Andy Shevchenko wrote:
> On Thu, May 9, 2019 at 5:19 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> > Log messages with pci_dev, not pcie_device.  Factor out common message
> > prefixes with dev_fmt().
> >
> > Example output change:
> >
> >   - aer 0000:00:00.0:pci002: AER enabled with IRQ ...
> >   + pcieport 0000:00:00.0: AER: enabled with IRQ ...
> 
> > +               pci_err(port, "request AER IRQ %d failed\n",
> >                         dev->irq);
> 
> Possible to be on one line?

Yep, fixed this in a previous patch.

> > +                       pci_warn(edev->port,
> > +                                "AER service is not initialized\n");
> 
> checkpatch won't complain if it would be on one line.

Right, thanks, fixed this too.

Bjorn