linux-kernel - Re: [PATCH v4 00/10] PCI: Log with pci_dev, not pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509214946.GF235064@google.com>
Date:   Thu, 9 May 2019 16:49:46 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Frederick Lawler <fred@...dlawl.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Keith Busch <keith.busch@...el.com>,
        Dongdong Liu <liudongdong3@...wei.com>,
        Sven Van Asbroeck <thesven73@...il.com>,
        linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/10] PCI: Log with pci_dev, not pcie_device

On Thu, May 09, 2019 at 08:49:08PM +0300, Andy Shevchenko wrote:
> On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> >
> > This is a collection of updates to Fred's v2 patches from:
> >
> >   https://lore.kernel.org/lkml/20190503035946.23608-1-fred@fredlawl.com
> >
> > and some follow-on discussion.
> >
> 
> For non-commented patches,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> For the commented ones, I hope you will address them, and then my tag
> applies for them as well.

Thanks, Andy and Keith, I really appreciate you taking a look.  Andy,
I added your tag to all except these:

> >   PCI/PME: Replace dev_printk(KERN_DEBUG) with dev_info()
> >   PCI/DPC: Log messages with pci_dev, not pcie_device

because I didn't make the capitalization and other message changes you
pointed out.  I'd totally be fine with those changes, but I don't
think we have time to do a complete job of it for this cycle.

Bjorn