linux-kernel - Re: [PATCH v1 2/2] fsopen: use square brackets around "fscontext"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509153902.tqkoooxtviafrla5@brauner.io>
Date:   Thu, 9 May 2019 17:39:04 +0200
From:   Christian Brauner <christian@...uner.io>
To:     viro@...iv.linux.org.uk, dhowells@...hat.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] fsopen: use square brackets around "fscontext"

On Wed, May 08, 2019 at 05:25:09PM +0200, Christian Brauner wrote:
> Make the name of the anon inode fd "[fscontext]" instead of "fscontext".
> This is minor but most core-kernel anon inode fds carry square brackets
> around their name (cf. [1]). For the sake of consistency lets do the same

This "(cf. [1])" reference was supposed to point to the list below. But
since I rewrote the paragraph it can simply be dropped.  Sorry for the
oversight.

Christian

> for the mount api:
> 
> [eventfd]
> [eventpoll]
> [fanotify]
> [fscontext]
> [io_uring]
> [pidfd]
> [signalfd]
> [timerfd]
> [userfaultfd]
> 
> Signed-off-by: Christian Brauner <christian@...uner.io>
> ---
>  fs/fsopen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fsopen.c b/fs/fsopen.c
> index a38fa8c616cf..83d0d2001bb2 100644
> --- a/fs/fsopen.c
> +++ b/fs/fsopen.c
> @@ -92,7 +92,7 @@ static int fscontext_create_fd(struct fs_context *fc)
>  {
>  	int fd;
>  
> -	fd = anon_inode_getfd("fscontext", &fscontext_fops, fc,
> +	fd = anon_inode_getfd("[fscontext]", &fscontext_fops, fc,
>  			      O_RDWR | O_CLOEXEC);
>  	if (fd < 0)
>  		put_fs_context(fc);
> -- 
> 2.21.0
>