linux-kernel - Re: [PATCH 7/9] genirq/timings: Add selftest for circular array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b32ff71b-8541-e135-11f2-7455ebc2b8c6@linaro.org>
Date:   Mon, 13 May 2019 13:03:03 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Kees Cook <keescook@...omium.org>,
        Petr Mladek <pmladek@...e.com>,
        Matthew Wilcox <willy@...radead.org>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        Mikulas Patocka <mpatocka@...hat.com>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Robin Murphy <robin.murphy@....com>,
        Sri Krishna chowdary <schowdary@...dia.com>,
        Changbin Du <changbin.du@...el.com>
Subject: Re: [PATCH 7/9] genirq/timings: Add selftest for circular array

On 13/05/2019 12:50, Andy Shevchenko wrote:
> On Mon, May 13, 2019 at 12:29:51PM +0200, Daniel Lezcano wrote:
>> Due to the complexity of the code and the difficulty to debug it,
>> let's add some selftests to the framework in order to spot issues or
>> regression at boot time when the runtime testing is enabled for this
>> subsystem.
>>
>> This tests the circular buffer at the limits and validates:
>>  - the encoding / decoding of the values
>>  - the macro to browse the irq timings circular buffer
>>  - the function to push data in the circular buffer
> 
>>  kernel/irq/timings.c | 119 +++++++++++++++++++++++++++++++++++++++++++
> 
> Is it possible to have it in a separate C-file?

It is possible but I would like to keep the selftest in the same file in
order to keep all the structures and functions self-contained.

>> +config TEST_IRQ_TIMINGS
>> +	bool "IRQ timings selftest"
> 
>> +	default n
> 
> This is already default.

Right, thanks for the review.

>> +	depends on IRQ_TIMINGS
>> +	help
>> +	  Enable this option to test the irq timings code on boot.
>> +
>> +	  If unsure, say N.
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog