linux-kernel - Re: [5/5] Coccinelle: put_device: Merge two SmPL when constraints into one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 May 2019 14:35:12 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Gilles Muller <Gilles.Muller@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Wen Yang <wen.yang99@....com.cn>, cocci@...teme.lip6.fr,
        linux-kernel@...r.kernel.org, Yi Wang <wang.yi59@....com.cn>
Subject: Re: [5/5] Coccinelle: put_device: Merge two SmPL when constraints
 into one

>> Combine the exclusion specifications into a disjunction for the semantic
>> patch language so that this argument is referenced only once there.
…
> NACK.  This hurts readability

I suggest to reconsider such readability concerns once more.
Can corresponding software limitations be adjusted any further?


> and gives no practical benefit.

I guess that you know better which aspects can matter also here
for software fine-tuning.


>> +++ b/scripts/coccinelle/free/put_device.cocci
>> @@ -22,8 +22,7 @@ id = of_find_device_by_node@p1(x)
>>  if (id == NULL || ...) { ... return ...; }
>>  ... when != put_device(&id->dev)
>>      when != id = (T6)(e)
>> -    when != platform_device_put(id)
>> -    when != of_dev_put(id)
>> +    when != \( platform_device_put \| of_dev_put \) (id)

Can the reduction of a bit of duplicate SmPL code result in nicer
run time characteristics?

Regards,
Markus