linux-kernel - RE: [PATCH] nvme/pci: Use host managed power state for suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ab8274ef1ce46fcae54a50abc76ae4a@AUSX13MPC105.AMER.DELL.COM>
Date:   Mon, 13 May 2019 14:54:49 +0000
From:   <Mario.Limonciello@...l.com>
To:     <kbusch@...nel.org>
CC:     <keith.busch@...el.com>, <hch@....de>, <sagi@...mberg.me>,
        <linux-nvme@...ts.infradead.org>, <rafael@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <kai.heng.feng@...onical.com>
Subject: RE: [PATCH] nvme/pci: Use host managed power state for suspend

> -----Original Message-----
> From: Keith Busch <kbusch@...nel.org>
> Sent: Monday, May 13, 2019 9:38 AM
> To: Limonciello, Mario
> Cc: keith.busch@...el.com; hch@....de; sagi@...mberg.me; linux-
> nvme@...ts.infradead.org; rafael@...nel.org; linux-kernel@...r.kernel.org; linux-
> pm@...r.kernel.org; kai.heng.feng@...onical.com
> Subject: Re: [PATCH] nvme/pci: Use host managed power state for suspend
> 
> 
> [EXTERNAL EMAIL]
> 
> On Mon, May 13, 2019 at 02:24:41PM +0000, Mario.Limonciello@...l.com wrote:
> > This was not a disk with HMB, but with regard to the HMB I believe it needs to be
> > removed during s0ix so that there isn't any mistake that SSD thinks it can access
> HMB
> > memory in s0ix.
> 
> Is that really the case, though? Where may I find that DMA is not
> allowed in this state? I just want an authoritative reference to attach
> to the behavior.

The Intel DMA controller suspend callbacks in drivers/dma/idma64.c look to me to
turn off the controller.

And NVME spec made it sound to me that while in a low power state it shouldn't
be available if the memory isn't available.

NVME spec in 8.9:

"Host software should request that the controller release the
assigned ranges prior to a shutdown event, a Runtime D3 event, or any other event
that requires host software to reclaim the assigned ranges."