linux-kernel - Re: [PATCH] nvme/pci: Use host managed power state for suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190513145708.GA25897@lst.de>
Date:   Mon, 13 May 2019 16:57:08 +0200
From:   Christoph Hellwig <hch@....de>
To:     Mario.Limonciello@...l.com
Cc:     kbusch@...nel.org, keith.busch@...el.com, hch@....de,
        sagi@...mberg.me, linux-nvme@...ts.infradead.org,
        rafael@...nel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, kai.heng.feng@...onical.com
Subject: Re: [PATCH] nvme/pci: Use host managed power state for suspend

On Mon, May 13, 2019 at 02:54:49PM +0000, Mario.Limonciello@...l.com wrote:
> The Intel DMA controller suspend callbacks in drivers/dma/idma64.c look to me to
> turn off the controller.

How is that relevant?  That thing is neither a NVMe controller, nor
even an PCIe device..

> And NVME spec made it sound to me that while in a low power state it shouldn't
> be available if the memory isn't available.
> 
> NVME spec in 8.9:
> 
> "Host software should request that the controller release the
> assigned ranges prior to a shutdown event, a Runtime D3 event, or any other event
> that requires host software to reclaim the assigned ranges."

The last part of the quoted text is the key - if the assigned range
is reclaimed, that is the memory is going to be used for something else,
we need to release the ranges.  But we do not release the ranges,
as we want to keep the memory in use so that we can quickly use it
again.